move index pattern to Library #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
changed the title
Codecov Report
@@ Coverage Diff @@
## workspace #91 +/- ##
=============================================
- Coverage 65.78% 65.76% -0.02%
=============================================
Files 3334 3334
Lines 64441 64456 +15
Branches 10258 10260 +2
=============================================
Hits 42390 42390
- Misses 19482 19497 +15
Partials 2569 2569
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wanglam
reviewed
Aug 18, 2023
Signed-off-by: Hailong Cui <ihailong@amazon.com>
wanglam
approved these changes
Aug 18, 2023
ruanyl
approved these changes
Aug 18, 2023
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* move index pattern to libaray Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 31, 2023
* move index pattern to libaray Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 15, 2023
* move index pattern to libaray Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com>
raintygao
added a commit
that referenced
this pull request
Oct 10, 2023
…ement and SavedObject management as standalone app, retire dashboard management (#208) * feat: init retire dashboard management Signed-off-by: tygao <tygao@amazon.com> * move index pattern to Library (#91) * move index pattern to libaray Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> index pattern always show under library Signed-off-by: Hailong Cui <ihailong@amazon.com> * functional test Signed-off-by: Hailong Cui <ihailong@amazon.com> * feat: move data source / advanced settings / saved objects management out of Dashboard management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: fix failed overview header ut Signed-off-by: tygao <tygao@amazon.com> * fix: deeplink inside saved objects management page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test fail Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test for each page wrapper Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * remove management dependency Signed-off-by: Hailong Cui <ihailong@amazon.com> * test: update cypress config to use workspace branch Signed-off-by: tygao <tygao@amazon.com> * Replace ManagementAppMountParams with AppMountParameters Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
wanglam
pushed a commit
that referenced
this pull request
Feb 26, 2024
…ement and SavedObject management as standalone app, retire dashboard management (#208) * feat: init retire dashboard management Signed-off-by: tygao <tygao@amazon.com> * move index pattern to Library (#91) * move index pattern to libaray Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> index pattern always show under library Signed-off-by: Hailong Cui <ihailong@amazon.com> * functional test Signed-off-by: Hailong Cui <ihailong@amazon.com> * feat: move data source / advanced settings / saved objects management out of Dashboard management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: fix failed overview header ut Signed-off-by: tygao <tygao@amazon.com> * fix: deeplink inside saved objects management page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test fail Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test for each page wrapper Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * remove management dependency Signed-off-by: Hailong Cui <ihailong@amazon.com> * test: update cypress config to use workspace branch Signed-off-by: tygao <tygao@amazon.com> * Replace ManagementAppMountParams with AppMountParameters Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Mar 18, 2024
…ement and SavedObject management as standalone app, retire dashboard management (#208) * feat: init retire dashboard management Signed-off-by: tygao <tygao@amazon.com> * move index pattern to Library (#91) * move index pattern to libaray Signed-off-by: Hailong Cui <ihailong@amazon.com> * Remove it from Dashboards management when workspace is on Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> index pattern always show under library Signed-off-by: Hailong Cui <ihailong@amazon.com> * functional test Signed-off-by: Hailong Cui <ihailong@amazon.com> * feat: move data source / advanced settings / saved objects management out of Dashboard management Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: fix failed overview header ut Signed-off-by: tygao <tygao@amazon.com> * fix: deeplink inside saved objects management page Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test fail Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test for each page wrapper Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: some optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * remove management dependency Signed-off-by: Hailong Cui <ihailong@amazon.com> * test: update cypress config to use workspace branch Signed-off-by: tygao <tygao@amazon.com> * Replace ManagementAppMountParams with AppMountParameters Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr