Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect permission modes when checking workspace permissions #98

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Aug 22, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@ruanyl
Copy link
Owner

ruanyl commented Aug 22, 2023

FYI @raintygao has a similar PR #93

@SuZhou-Joe SuZhou-Joe merged commit a9ffe1b into ruanyl:workspace Aug 22, 2023
37 of 41 checks passed
SuZhou-Joe added a commit that referenced this pull request Aug 31, 2023
)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit that referenced this pull request Aug 31, 2023
)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants