Metrics #24
Open
Metrics #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Athishpranav2003
force-pushed
the
metrics
branch
from
82f9ff6 to
5b450c0
Compare
Athishpranav2003
force-pushed
the
metrics
branch
from
5b450c0 to
447825b
Compare
| @@ -1 +1,3 @@ | |||
| *.gem | |||
| nclude-dependencies | |||
There was a problem hiding this comment.
In general the lock file is not included in the plugins(since it depends on build env). Thats why i didnt include. I checked with other plugins too. Its the same
lib/fluent/plugin/filter_throttle.rb
Outdated
| desc <<~DESC | ||
| Whether to emit a metric when the rate limit is exceeded. The metric is fluentd_throttle_rate_limit_exceeded | ||
| DESC | ||
| config_param :group_emit_metrics, :bool, :default => false |
There was a problem hiding this comment.
Can we keep the name simple?
just enable_metrics should be fine.
lib/fluent/plugin/filter_throttle.rb
Outdated
| @@ -68,12 +83,26 @@ def configure(conf) | |||
|
|
|||
| raise "group_warning_delay_s must be >= 1" \ | |||
| unless @group_warning_delay_s >= 1 | |||
|
|
|||
| hostname = Socket.gethostname | |||
There was a problem hiding this comment.
Put the next few lines under the check if metrics enabled.
| end | ||
|
|
||
| def start | ||
| super | ||
|
|
||
| @counters = {} | ||
| # TODO add more relevant metrics to throttling | ||
| @metrics = {throttle_rate_limit_exceeded: get_counter(:fluentd_throttle_rate_limit_exceeded, "The exceeded rate of pods in the group")} |
There was a problem hiding this comment.
this can be a variable. I dont think we need a map here
There was a problem hiding this comment.
This was made as a map just to make it standard to add more metrics. It can act as a template to add more metrics by adding in the map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support to add prometheus metrics for observability for throttling of logs as requested here #15 . Opens more scope to add lot more metrics related to throttling. Corresponding tests are also added to the testing script and verified. Few plugin versions have been bumped up inorder to avoid few build issues.