Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_html only considers some styles and not others #126

Closed
sixtyfive opened this issue Apr 7, 2022 · 1 comment · Fixed by #144
Closed

to_html only considers some styles and not others #126

sixtyfive opened this issue Apr 7, 2022 · 1 comment · Fixed by #144
Labels

Comments

@sixtyfive
Copy link

Not sure if this should be a bug report or a feature request. In any case, if there is an existing Issue for this, please just close, but I couldn't find one after searching for a while.

With a docx test file that includes the following styles applied to different words:

  • none
  • red
  • bold
  • italics
  • striked through
  • underscored

... and then converted to HTML by .paragraphs.first.to_html, I get the following styles back out:

  • text-align:left (which was apparently applied without me specifically having done so in Word; fair enough)
  • <strong>
  • <em>
  • text-decoration:underline

So color:red and <s> are missing.

Is that something where every style has to be explicitly implemented or should this be working? If it's the former I'd like to give it a shot to implement it if there could be a little bit of guidance as to what places of the code to look at?

@supraja-trd
Copy link
Contributor

Hi @satoryu , the above is fixed in my PR : #144 . Kindly review it and let me know further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants