Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support color and strike tag in to_html #144

Merged

Conversation

supraja-trd
Copy link
Contributor

@supraja-trd supraja-trd commented Nov 17, 2023

To Fix : #126

  1. Supports color tag in style
  2. Supports < s > tag

@supraja-trd
Copy link
Contributor Author

Hi @satoryu , Kindly review this PR . I do not have write access for the repo. Let me know how to proceed further to have my code merged to repo .

@supraja-trd
Copy link
Contributor Author

Hi @satoryu , Are we good to merge this PR ? I don't have write access for this repository . Could you let me know how to proceed ?

@manovasanth1227
Copy link
Contributor

Hi @satoryu , can you pls review this PR ?

Copy link
Member

@satoryu satoryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supraja-trd thank you for your pull request and your effort!

@satoryu satoryu merged commit 9ea9595 into ruby-docx:master Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_html only considers some styles and not others
3 participants