Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with warnings enabled #1425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bf4
Copy link

@bf4 bf4 commented Jun 14, 2016

Should help clean up warnings in gems or apps that use Grape ;)

refs:

Should help clean up warnings in gems or apps that use Grape ;)

refs:
- http://mislav.net/2011/06/ruby-verbose-mode/
@dblock
Copy link
Member

dblock commented Jun 14, 2016

I looked at the output in https://travis-ci.org/ruby-grape/grape/jobs/137408689 and there're some juicy ones that seem like they should be fixed. Would you like to address them as part of this PR?

@bf4
Copy link
Author

bf4 commented Jun 14, 2016

Depends on how soon you'd like this merged... :) we run AMS tests w warnings on and grape is main offender, but otherwise I'm juggling a bunch of stuff right now (as are we all)

B mobile phone

On Jun 14, 2016, at 7:00 AM, Daniel Doubrovkine (dB.) @dblockdotorg notifications@github.com wrote:

I looked at the output in https://travis-ci.org/ruby-grape/grape/jobs/137408689 and there're some juicy ones that seem like they should be fixed. Would you like to address them as part of this PR?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@dblock
Copy link
Member

dblock commented Jun 14, 2016

I'll wait or will pick this up. I agree that this is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants