Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error on relying party #30

Conversation

Vagab
Copy link
Contributor

@Vagab Vagab commented Jun 24, 2023

No description provided.

@Vagab Vagab changed the base branch from main to 2023-06-23-refactor-to-use-webauthn-rack-helpers June 24, 2023 11:36
@tcannonfodder tcannonfodder self-requested a review June 24, 2023 15:55
@tcannonfodder tcannonfodder merged commit 74d8e26 into ruby-passkeys:2023-06-23-refactor-to-use-webauthn-rack-helpers Jun 24, 2023
@tcannonfodder
Copy link
Contributor

tcannonfodder commented Jun 24, 2023

Due to a mistake on my part, this actually got merged into the main branch in #32

@Vagab
Copy link
Contributor Author

Vagab commented Jun 24, 2023

you meant #32? Why a mistake though, I thought that was intentional

@tcannonfodder
Copy link
Contributor

I did mean #32, thanks for catching that! The mistake was that I meant to merge that PR directly into main; because I'd already merged in the previous branch; because I didn't read exactly which branch it was going to merge into 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants