ReauthenticationControllerConcern and SessionsControllerConcern raise NoMethodError if the relying_party has not been overridden

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## [Unreleased]
 
+- `ReauthenticationControllerConcern` and `SessionsControllerConcern` raise `NoMethodError` if the `relying_party` has not been overridden
+  - https://github.com/ruby-passkeys/devise-passkeys/pull/32
 - [Bump to warden-webauthn 0.2.1](https://github.com/ruby-passkeys/devise-passkeys/pull/29/commits/d825ffded91aa98801bdd5530442761aa60538f9)
 - [Use `Warden::WebAuthn::RackHelper.set_relying_party_in_request_env` to streamline setup](https://github.com/ruby-passkeys/devise-passkeys/pull/29/commits/7b7d50129ebe83b0a224d0ace0e4cff8ea407f4a)
 - [Refactor PasskeysControllerConcern to have clearer credential verify with `verify_credential_integrity`](https://github.com/ruby-passkeys/devise-passkeys/pull/29/commits/f1400cb4b217c20b9e74fda3f55f74284e373d25)

lib/devise/passkeys/controllers/reauthentication_controller_concern.rb

@@ -70,7 +70,7 @@ def delete_reauthentication_challenge
         end
 
         def relying_party
-          raise "need to define relying_party for this SessionsController"
+          raise NoMethodError, "need to define relying_party for this #{self.class.name}"
         end
       end
     end

lib/devise/passkeys/controllers/sessions_controller_concern.rb

@@ -30,7 +30,7 @@ def new_challenge
         protected
 
         def relying_party
-          raise "need to define relying_party for this SessionsController"
+          raise NoMethodError, "need to define relying_party for this #{self.class.name}"
         end
       end
     end

test/devise/passkeys/controllers/test_reauthentication_controller_concern.rb

@@ -312,10 +312,10 @@ def root_path
     Rails.application.reload_routes!
   end
 
-  test "#new_challenge: raises RuntimeError if set_relying_party_in_request_env has not been implemented" do
+  test "#new_challenge: raises NoMethodError if relying_party has not been implemented" do
     user = User.create!(email: "test@test.com")
     sign_in(user)
-    assert_raises RuntimeError do
+    assert_raises NoMethodError do
       post "/reauthentication/new_challenge"
     end
   end

test/devise/passkeys/controllers/test_sessions_controller_concern.rb

@@ -104,8 +104,8 @@ def resource_name
     Rails.application.reload_routes!
   end
 
-  test "#new_challenge: raises RuntimeError if set_relying_party_in_request_env has not been implemented" do
-    assert_raises RuntimeError do
+  test "#new_challenge: raises RuntimeError if relying_party has not been implemented" do
+    assert_raises NoMethodError do
       post "/session/new_challenge"
     end
   end