Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add launchable integration" #1081

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Revert "Add launchable integration" #1081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
405dfcb
Revert "Use `github.sha` when running tests on the master branch"
ono-max Feb 19, 2024
753ba71
Revert "Add comment"
ono-max Feb 19, 2024
35f1e52
Revert "require "test/unit/runner/junitxml" if launchable env is conf…
ono-max Feb 19, 2024
ee689dd
Revert "Add launchable integration"
ono-max Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 1 addition & 36 deletions .github/workflows/protocol.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,6 @@ on:
pull_request:
branches: [ master ]

env:
# GITHUB_PULL_REQUEST_URL are used for commenting test reports in Launchable Github App.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/link.py#L42
GITHUB_PULL_REQUEST_URL: ${{ github.event.pull_request.html_url }}
# The following envs are necessary in Launchable tokenless authentication.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L20
LAUNCHABLE_ORGANIZATION: "ruby"
LAUNCHABLE_WORKSPACE: "debug"
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L71
GITHUB_PR_HEAD_SHA: ${{ github.event.pull_request.head.sha || github.sha }}

jobs:
test:

Expand All @@ -29,27 +18,6 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
# Set fetch-depth: 0 so that Launchable can receive commits information.
fetch-depth: 0
# Launchable requires Python and Java
# https://www.launchableinc.com/docs/resources/cli-reference/
- uses: actions/setup-python@v4
with:
python-version: "3.10"
- name: Set up JDK 1.8
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: '8'
# Setup Launchable
- name: Launchable - install command
run: pip install launchable
- name: Launchable - verify
run: launchable verify
- name: Launchable - record build
run: launchable record build --name ${GITHUB_PR_HEAD_SHA}

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -59,7 +27,4 @@ jobs:
run: |
bundle exec rake clobber
bundle exec rake compile
TESTOPTS="--runner=junitxml --junitxml-output-file=protocol.xml" bundle exec rake test_protocol
- name: Launchable - record tests
run: launchable record tests --flavor test=protocol --flavor os=ubuntu-latest --flavor ruby=${{ matrix.ruby-version }} file protocol.xml
if: always()
bundle exec rake test_protocol
37 changes: 1 addition & 36 deletions .github/workflows/ruby-macos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,6 @@ on:
pull_request:
branches: [ master ]

env:
# GITHUB_PULL_REQUEST_URL are used for commenting test reports in Launchable Github App.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/link.py#L42
GITHUB_PULL_REQUEST_URL: ${{ github.event.pull_request.html_url }}
# The following envs are necessary in Launchable tokenless authentication.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L20
LAUNCHABLE_ORGANIZATION: "ruby"
LAUNCHABLE_WORKSPACE: "debug"
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L71
GITHUB_PR_HEAD_SHA: ${{ github.event.pull_request.head.sha || github.sha }}

jobs:
test:

Expand All @@ -29,27 +18,6 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
# Set fetch-depth: 0 so that Launchable can receive commits information.
fetch-depth: 0
# Launchable requires Python and Java
# https://www.launchableinc.com/docs/resources/cli-reference/
- uses: actions/setup-python@v4
with:
python-version: "3.10"
- name: Set up JDK 1.8
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: '8'
# Setup Launchable
- name: Launchable - install command
run: pip install launchable
- name: Launchable - verify
run: launchable verify
- name: Launchable - record build
run: launchable record build --name ${GITHUB_PR_HEAD_SHA}

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -59,7 +27,4 @@ jobs:
run: |
bundle exec rake clobber
bundle exec rake compile
TESTOPTS="--runner=junitxml --junitxml-output-file=ruby-macos.xml" bundle exec rake test_console
- name: launchable record tests
run: launchable record tests --flavor test=console --flavor os=macos-latest --flavor ruby=${{ matrix.ruby-version }} file ruby-macos.xml
if: always()
bundle exec rake test_console
37 changes: 1 addition & 36 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,6 @@ on:
pull_request:
branches: [ master ]

env:
# GITHUB_PULL_REQUEST_URL are used for commenting test reports in Launchable Github App.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/link.py#L42
GITHUB_PULL_REQUEST_URL: ${{ github.event.pull_request.html_url }}
# The following envs are necessary in Launchable tokenless authentication.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L20
LAUNCHABLE_ORGANIZATION: "ruby"
LAUNCHABLE_WORKSPACE: "debug"
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L71
GITHUB_PR_HEAD_SHA: ${{ github.event.pull_request.head.sha || github.sha }}

jobs:
test:

Expand All @@ -29,27 +18,6 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
# Set fetch-depth: 0 so that Launchable can receive commits information.
fetch-depth: 0
# Launchable requires Python and Java
# https://www.launchableinc.com/docs/resources/cli-reference/
- uses: actions/setup-python@v4
with:
python-version: "3.10"
- name: Set up JDK 1.8
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: '8'
# Setup Launchable
- name: Launchable - install command
run: pip install launchable
- name: Launchable - verify
run: launchable verify
- name: Launchable - record build
run: launchable record build --name ${GITHUB_PR_HEAD_SHA}

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -59,7 +27,4 @@ jobs:
run: |
bundle exec rake clobber
bundle exec rake compile
TESTOPTS="--runner=junitxml --junitxml-output-file=ruby.xml" bundle exec rake test_console
- name: launchable record tests
run: launchable record tests --flavor test=console --flavor os=ubuntu-latest --flavor ruby=${{ matrix.ruby-version }} file ruby.xml
if: always()
bundle exec rake test_console
37 changes: 1 addition & 36 deletions .github/workflows/test_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,6 @@ on:
pull_request:
branches: [ master ]

env:
# GITHUB_PULL_REQUEST_URL are used for commenting test reports in Launchable Github App.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/link.py#L42
GITHUB_PULL_REQUEST_URL: ${{ github.event.pull_request.html_url }}
# The following envs are necessary in Launchable tokenless authentication.
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L20
LAUNCHABLE_ORGANIZATION: "ruby"
LAUNCHABLE_WORKSPACE: "debug"
# https://github.com/launchableinc/cli/blob/v1.80.1/launchable/utils/authentication.py#L71
GITHUB_PR_HEAD_SHA: ${{ github.event.pull_request.head.sha || github.sha }}

jobs:
test:

Expand All @@ -29,27 +18,6 @@ jobs:

steps:
- uses: actions/checkout@v4
with:
# Set fetch-depth: 0 so that Launchable can receive commits information.
fetch-depth: 0
# Launchable requires Python and Java
# https://www.launchableinc.com/docs/resources/cli-reference/
- uses: actions/setup-python@v4
with:
python-version: "3.10"
- name: Set up JDK 1.8
uses: actions/setup-java@v3
with:
distribution: 'adopt'
java-version: '8'
# Setup Launchable
- name: Launchable - install command
run: pip install launchable
- name: Launchable - verify
run: launchable verify
- name: Launchable - record build
run: launchable record build --name ${GITHUB_PR_HEAD_SHA}

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand All @@ -59,7 +27,4 @@ jobs:
run: |
bundle exec rake clobber
bundle exec rake compile
TESTOPTS="--runner=junitxml --junitxml-output-file=test_test.xml" bundle exec rake test_test
- name: launchable record tests
run: launchable record tests --flavor test=test-framework --flavor os=ubuntu-latest --flavor ruby=${{ matrix.ruby-version }} file test_test.xml
if: always()
bundle exec rake test_test
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ gem "rake-compiler"
gem "test-unit", "~> 3.0"
gem "test-unit-rr"
gem "json-schema"
gem "test-unit-runner-junitxml"
7 changes: 0 additions & 7 deletions test/support/test_case.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,6 @@

require_relative 'assertions'

# Load this library only in the debug CI to prevent LoadError
# when these tests are executed in ruby/ruby.
if ENV['LAUNCHABLE_ORGANIZATION'] && ENV['LAUNCHABLE_WORKSPACE']
# "test/unit/runner/junitxml" is used for reporting test result in JUnit XML format.
require "test/unit/runner/junitxml"
end

module DEBUGGER__
class TestCase < Test::Unit::TestCase
TestInfo = Struct.new(:queue, :mode, :prompt_pattern, :remote_info,
Expand Down
Loading