Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default max_lines when calling up & down #1094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use default max_lines when calling up & down #1094

wants to merge 1 commit into from
+58 −20

Commits on Oct 26, 2024

  1. Use default max_lines when calling up & down 

    Both `up` and `down` only show 1 source line when called, I think it
would be more useful if they provided more context. This removes the
`max_lines: 1` kwarg when they call `show_src`. `max_lines` in `show_src` will default
to `CONFIG[:show_src_lines]`[^1].

[^1]:(https://github.com/ruby/debug/blob/0b77e8294b5b220b3b2a089bf09f94808654899a/lib/debug/thread_client.rb#L510)
    @HeyNonster
    HeyNonster committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    98a7521 View commit details
    Browse the repository at this point in the history