Skip to content

Commit

Permalink
Remove unused InputMethod#initialize (#635)
Browse files Browse the repository at this point in the history
* Remove unused InputMethod#initialize

The constructor takes a `file_name` argument, but it is never used. The
only input method that needs a file is `FileInputMethod`, which has its
own constructor to take a file object directly.

So the constructor in `InputMethod` is not needed and its child classes
don't need to call `super` in their constructors.

* Remove unused FileInputMethod#file_name
  • Loading branch information
st0012 authored Aug 7, 2023
1 parent bbd2044 commit 153b1e9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
15 changes: 0 additions & 15 deletions lib/irb/input-method.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,7 @@
require 'reline'

module IRB
STDIN_FILE_NAME = "(line)" # :nodoc:
class InputMethod

# Creates a new input method object
def initialize(file = STDIN_FILE_NAME)
@file_name = file
end
# The file name of this input method, usually given during initialization.
attr_reader :file_name

# The irb prompt associated with this input method
attr_accessor :prompt

Expand Down Expand Up @@ -59,7 +50,6 @@ def inspect
class StdioInputMethod < InputMethod
# Creates a new input method object
def initialize
super
@line_no = 0
@line = []
@stdin = IO.open(STDIN.to_i, :external_encoding => IRB.conf[:LC_MESSAGES].encoding, :internal_encoding => "-")
Expand Down Expand Up @@ -133,12 +123,9 @@ def open(file, &block)

# Creates a new input method object
def initialize(file)
super
@io = file.is_a?(IO) ? file : File.open(file)
@external_encoding = @io.external_encoding
end
# The file name of this input method, usually given during initialization.
attr_reader :file_name

# Whether the end of this input method has been reached, returns +true+ if
# there is no more data to read.
Expand Down Expand Up @@ -186,7 +173,6 @@ def initialize
if Readline.respond_to?(:encoding_system_needs)
IRB.__send__(:set_encoding, Readline.encoding_system_needs.name, override: false)
end
super

@line_no = 0
@line = []
Expand Down Expand Up @@ -267,7 +253,6 @@ class RelineInputMethod < InputMethod
# Creates a new input method object using Reline
def initialize
IRB.__send__(:set_encoding, Reline.encoding_system_needs.name, override: false)
super

@line_no = 0
@line = []
Expand Down
1 change: 0 additions & 1 deletion test/irb/helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class TestInputMethod < ::IRB::InputMethod
attr_reader :list, :line_no

def initialize(list = [])
super("test")
@line_no = 0
@list = list
end
Expand Down

0 comments on commit 153b1e9

Please sign in to comment.