Make rendering test faster using updated yamatanooroti #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
force-pushed
the
new_yamatanooroti
branch
from
d9bb6b6
to
d48a856
Compare
tompng
force-pushed
the
new_yamatanooroti
branch
from
d48a856
to
0b2e121
Compare
tompng
commented
Sep 16, 2024
| # because pager is invoked, foobar will not be evaluated | ||
| assert_not_match(/foobar/, screen) | ||
| assert_screen(/\A(?!foobar)/) |
There was a problem hiding this comment.
Yamatanooroti does not have assert_not_screen. We need to use negative lookahead to perform a retryable assertion.
st0012
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes test_rendering faster. Yamatanooroti's wait time is reduced from 0.1 sec to 0.01 sec
test_yamatanooroti(vterm-yamatanooroti head): 37.58 sec → 10.72 secstartup_message
We don't need
puts 'start IRB'. It does not mean IRB is ready for input. We should check the prompt withstartup_message: /irb\(main\)/close
It does not only close_input but read few bytes and terminates process immediately.
Calling close before assert_screen sometimes terminates process before reading the last output.