Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change debug test workaround to use ENV RUBY_DEBUG_TEST_UI #1014

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Change debug test workaround to use ENV RUBY_DEBUG_TEST_UI #1014

merged 1 commit into from
Oct 8, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Oct 8, 2024

Fixes #990
Use ENV['RUBY_DEBUG_TEST_UI'] for test-only workaround.

ima1zumi
ima1zumi approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ima1zumi ima1zumi merged commit 9933584 into ruby:master Oct 8, 2024
30 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 8, 2024
@tompng @matzbot
[ruby/irb] Change debug test workaround to use ENV
cb19dfc 
RUBY_DEBUG_TEST_UI
(ruby/irb#1014)

ruby/irb@9933584754
@tompng tompng deleted the env_debug_test_workaround branch October 8, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

With irb --noreadline --nomultiline there is an unnecessary newline before each prompt
3 participants
@tompng @st0012 @ima1zumi