Use Ripper.sexp instead of Regexp for completion #616
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces completion method from Regex based to Ripper.sexp base
Pros
Can complete these codes that Regexp based implementation provides wrong completion.
Cons
Cannot complete if there are syntax error before cursor. Regexp based can complete these.
Limitation
Cannot complete these code now. I can support this later (about +40 lines).
Why not RubyVM::AbstractSyntaxTree or YARP
Using RubyVM::AbstractSyntaxTree (and I beleave YARP too) is easier than Ripper.sexp but:
Future plan
Use RBS to provide powerful completion