Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate multi-irb commands #654

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Deprecate multi-irb commands #654

merged 2 commits into from
Aug 2, 2023

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 22, 2023

This is part of #653

  • Print deprecated message when any of the commands are used

    irb(main):002:0> jobs
Multi-irb commands are deprecated and will be removed in IRB 2.0.0.
If you have any use case for multi-irb, please leave a comment at https://github.com/ruby/irb/issues/653
=> #0->irb on main (#<Thread:0x0000000104dab128 run>: running)

  • Put related commands under Multi-irb category with a deprecated label

    Multi-irb (DEPRECATED)
  irb            Start a child IRB.
  jobs           List of current sessions.
  fg             Switches to the session of the given number.
  kill           Kills the session with the given number.

@st0012 st0012 added the enhancement New feature or request label Jul 22, 2023
@st0012
Deprecate multi-irb commands
20f2a40 
- Print deprecated message when any of the commands are used
- Put related commands under `Multi-irb` category with a deprecated
  label
@st0012
Update readme
2379a41
@st0012 st0012 requested a review from tompng August 1, 2023 16:52
@tompng tompng merged commit 861731a into master Aug 2, 2023
47 checks passed
@tompng tompng deleted the deprecate-multi-irb branch August 2, 2023 18:35
matzbot pushed a commit to ruby/ruby that referenced this pull request Aug 2, 2023
@st0012 @matzbot
[ruby/irb] Deprecate multi-irb commands
32e828b 
(ruby/irb#654)

* Deprecate multi-irb commands

- Print deprecated message when any of the commands are used
- Put related commands under `Multi-irb` category with a deprecated
  label

* Update readme

ruby/irb@861731ac12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tompng tompng tompng approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @tompng