Avoid overriding user's irb_name setting in debugger integration
#688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
avoid-overriding-irb-name
branch
5 times, most recently
from
382c311
to
48a5a61
Compare
Instead of always setting `irb_name` to `irb:rdbg`, it should respect the user's setting and only append `:rdbg` to it.
st0012
force-pushed
the
avoid-overriding-irb-name
branch
from
48a5a61
to
986c7ca
Compare
st0012
force-pushed
the
avoid-overriding-irb-name
branch
from
986c7ca
to
9bd6dfc
Compare
tompng
approved these changes
Aug 21, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 21, 2023
integration (ruby/irb#688) * Avoid overriding user's irb_name setting in debugger integration Instead of always setting `irb_name` to `irb:rdbg`, it should respect the user's setting and only append `:rdbg` to it. * Introduce write_rc test helper ruby/irb@2ce7593351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always setting
irb_nametoirb:rdbg, it should respect the user's setting and only append:rdbgto it.