Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename current completor to RegexpCompletor and refactored for future extension #707

Merged
merged 9 commits into from
Oct 11, 2023
Merged

Rename current completor to RegexpCompletor and refactored for future extension #707

merged 9 commits into from
Oct 11, 2023

Commits on Oct 10, 2023

  1. Move completion implementation to completion/regexp_completor for fut… 

    …ure extension
    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    23c3fe0 View commit details
    Browse the repository at this point in the history

  2. Remove constant CompletionProc and PerfectMatchedProc and add a class… 

    … method
    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    cf20137 View commit details
    Browse the repository at this point in the history

  3. Move document display logic to InputCompletor. Each completor only ne… 

    …ed to implement `completion_caididates` and `doc_namespace`
    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    cb20550 View commit details
    Browse the repository at this point in the history

  4. Move display_document logic to RelineInputMethod

    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2088784 View commit details
    Browse the repository at this point in the history

  5. Use RegexpCompletor directly. Not through class method of InputComple… 

    …tor.
    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a92c2a2 View commit details
    Browse the repository at this point in the history

  6. RegexpCompletor extends BaseCompletor, move back definition to comple… 

    …tion.rb
    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9bc85a0 View commit details
    Browse the repository at this point in the history

  7. Move display_document test to input_method test

    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    43302ae View commit details
    Browse the repository at this point in the history

  8. Stop re-initialize completor on each completion phase

    @tompng
    tompng committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f618538 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Store completor to ReadlineInputMethod's iver

    @tompng
    tompng committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    d41a103 View commit details
    Browse the repository at this point in the history