-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't enable test mode by TERM=dumb #660
Comments
I haven't looked much into the issue yet, but we need to be very cautious about this change because many projects, like Rails and debug, use |
FWIW, if we're talking about Reline inside Emacs, then removing special handling for |
If we're doing this, we also need to disable ▽ and "\e[6n" (Query Cursor Position) if TERM=dumb. |
Problem
In IRB's test code, TERM=dumb triggers Reline's test mode io
Reline::GeneralIO
(unlike the name, this is not a general io)In practice, TERM=dumb seems to be used in real world. (example: pry/pry#2303)
It will unintentionally enables Reline's test mode and cause problems.
I think Reline should not use TERM=dumb to enable test mode. We need another way to enable it, or remove this test mode after fixing IRB's test not to depend on this.
The text was updated successfully, but these errors were encountered: