Set default value for Reline.input, Reline.output and Reline.special_prefixes #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tompng
reviewed
Jan 15, 2025
| if val.respond_to?(:getc) && io_gate.respond_to?(:input=) | ||
| io_gate.input = val | ||
| if val.nil? | ||
| io_gate.input = STDIN |
There was a problem hiding this comment.
Reline::Windows have attr_writer :output but does not have input= method and it does not support changing input.
We need a check like before, or add a no-op input= method to Reline::Windows.
tompng
reviewed
Jan 15, 2025
| if val.nil? | ||
| @output = STDOUT | ||
| io_gate.output = STDOUT | ||
| return |
There was a problem hiding this comment.
Maybe just val = STDOUT is enough and simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #774
I have changed that default values are assigned to
Reline.input=,Reline.output=, andReline.special_prefixes=whennilis passed to these methods. This change aligns the behavior of Reline with that of readline-ext.readline-ext sets
special_prefixes=nilto nil, but I think the method name suggests that a string is expected.Reline.special_prefixeshas been modified to default to an empty string instead ofnil.readline-ext
https://github.com/ruby/readline-ext/blob/9ee1b1a2f848ebb98b8ea07969a100dd24548411/ext/readline/readline.c#L561-L629
https://github.com/ruby/readline-ext/blob/9ee1b1a2f848ebb98b8ea07969a100dd24548411/ext/readline/readline.c#L1463-L1494