Dedupe require paths completion

ruby · Dec 3, 2023 · ec66984 · ec66984
1 parent 6d0a9d1
commit ec66984
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/Gemfile b/Gemfile
@@ -5,6 +5,7 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in repl_type_completor.gemspec
 gemspec
 
+gem 'irb', '>= 1.10.0'
 gem 'rake', '~> 13.0'
 gem 'test-unit'
 gem 'test-unit-ruby-core'

diff --git a/lib/repl_type_completor/require_paths.rb b/lib/repl_type_completor/require_paths.rb
@@ -12,7 +12,7 @@ def require_completions(target_path)
             with_cache [:requireable_paths, base_dir] do
               requireable_paths(base_dir)
             end
-          end.sort
+          end.uniq.sort
         end
         paths.filter_map do |path|
           [*dir, path].join('/') if path.start_with?(target)

diff --git a/test/repl_type_completor/test_require_paths.rb b/test/repl_type_completor/test_require_paths.rb
@@ -9,6 +9,7 @@ def test_require_paths
       assert_include ReplTypeCompletor::RequirePaths.require_completions('repl_type_com'), 'repl_type_completor'
       assert_include ReplTypeCompletor::RequirePaths.require_completions('repl_type_com'), 'repl_type_completor/version'
       assert_equal ['repl_type_completor/version'], ReplTypeCompletor::RequirePaths.require_completions('repl_type_completor/vers')
+      assert_equal 1, ReplTypeCompletor::RequirePaths.require_completions('ir').tally['irb']
     end
 
     def test_require_relative_paths