Expand specs for Thread variables #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code more consistent.
The old one was a copy-paste of the setter.
* Test with frozen Thread * Test with nil value which removes the entry * Test different key types
* Test with frozen Thread * Test different key types The key type behaviour differs from Thread#thread_variable_set, keys that raise a TypeError when setting result in a nil value when getting.
* Test with frozen Thread * Test different key types The key type behaviour is similar to Thread#thread_variable_get?
* Test different key types This shows the Symbol type being used as the internal type.
andrykonchin
approved these changes
Feb 7, 2024
…ble?/#thread_variables specs titles
andrykonchin
force-pushed
the
thread_variables
branch
from
decbe6d
to
89328e4
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.