Add spec to the result of Coverage lib for begin
#1149
Merged
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuramasafumi
force-pushed
the
coverage-with-begin
branch
from
b93d02a
to
74068ba
Compare
eregon
reviewed
Apr 22, 2024
| @@ -0,0 +1,24 @@ | |||
| require_relative '../../spec_helper' | |||
There was a problem hiding this comment.
Files almost always reflect a method, so could you move this example to https://github.com/ruby/spec/blob/master/library/coverage/result_spec.rb ?
There was a problem hiding this comment.
Sorry for being late, it's done.
okuramasafumi
force-pushed
the
coverage-with-begin
branch
from
74068ba
to
b7a55d3
Compare
Ref: jruby/jruby#8173 This commit is intended to make sure `Coverage` library behaves the same for the code with `begin`. JRuby had an issue so this change will help JRuby and other implementations to avoid it.
okuramasafumi
force-pushed
the
coverage-with-begin
branch
from
b7a55d3
to
7e50f24
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: jruby/jruby#8173
I'm not sure if this is the right way to add a spec or not. Please point it out if I miss something or there's a better way.