Add specs for for loop with attribute target
#1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specs with safe navigation require a segfault with MRI until very recent versions (https://bugs.ruby-lang.org/issues/20468), so these had to be wrapped in eval blocks.
| n.should == 3 | ||
| end | ||
|
|
||
| ruby_version_is "3.4" do |
There was a problem hiding this comment.
I would also add a link to the issue. I suppose the fix will be backported soon so the version guard will be removed.
There was a problem hiding this comment.
I added the link, but the bug report doesn't mention anything about backports, so I'm not sure if we should be expecting it. But the link doesn't hurt.
I added specs for the syntax for a[0]/a[:a] in x as well, according to Prism these are different parse nodes than the regular for foo.bar in x
There was a problem hiding this comment.
We should use ruby_bug for this, and it should be backported (segfault fixes should basically always be backported)
andrykonchin
previously approved these changes
Jun 25, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs with safe navigation require a segfault with MRI until very recent versions (https://bugs.ruby-lang.org/issues/20468), so these had to be wrapped in eval blocks.