Extends specs of Exception#detailed_message #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a specific path for instances of RuntimeError, the other path (returning the name of the class) is used for every other instance, not just for subclasses of RuntimeError.
There is a specific code path for exceptions with an empty message. Test both the RuntimeError and another exception class. Move the existing code a bit, to keep the ordering/grouping of specs a bit more logical.
andrykonchin
approved these changes
Jun 27, 2024
|
Thank you! The logic related to highlighting seems not covered well enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few additional cases for empty messages