Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extends specs of Exception#detailed_message #1170

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Extends specs of Exception#detailed_message #1170

merged 2 commits into from
Jun 27, 2024

Commits on Jun 27, 2024

  1. Update specs for Exception#detailed_message without message 

    There is a specific path for instances of RuntimeError, the other path
(returning the name of the class) is used for every other instance, not
just for subclasses of RuntimeError.
    @herwinw
    herwinw committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1b3149d View commit details
    Browse the repository at this point in the history

  2. Add more specs for highlight in Exception#detailed_message 

    There is a specific code path for exceptions with an empty message. Test
both the RuntimeError and another exception class.
Move the existing code a bit, to keep the ordering/grouping of specs a
bit more logical.
    @herwinw
    herwinw committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    4489e05 View commit details
    Browse the repository at this point in the history