Replace specific constant tests with just type checks #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detailed in the attached issue, these constants can and do vary e.g. between architectures on Linux. Hardcoding and asserting that they are equal to specific values pretty much defeats the purpose of building these in at compile time. Instead, simply assert that they exist and are integers. Fixes: ruby#1150
eregon
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in the attached issue, these constants can and do vary e.g. between architectures on Linux. Hardcoding and asserting that they are equal to specific values pretty much defeats the purpose of building these in at compile time. Instead, simply assert that they exist and are integers.
Fixes: #1150