Better handling of ws_url, and avoid stripping query params from url #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stripping url/ws_url query params
|
Tests are failing |
|
Merged with other fixes manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes some compatibility issues with browserless v2 and possibly others.
An issue with the
parse_json_versionwas that it would turn the ws scheme into http, strip query params and request /json/version. This is the first problem, stripping query params which often include an auth token and other configuration.The second concern was that the
initializerwould override the ws_url based on what that endpoint would show, in the case of browserless that would be 0.0.0.0:3000. If the ws_url has been set, ferrum should not try to override that.This is my first OSS PR so I am sorry if I did some thing wrong.
#439