Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require missing dependencies #459

Merged
merged 1 commit into from
May 10, 2024
Merged

Require missing dependencies #459

merged 1 commit into from
May 10, 2024

Conversation

erickguan
Copy link
Contributor

@erickguan erickguan commented Apr 26, 2024

I intend to require 'ferrum/browser to start a browser. However, ferrum/browser.rb misses a few dependencies. I add them in this PR. This PR doesn't fix other ruby files though.

@route route merged commit 443b268 into rubycdp:main May 10, 2024
7 checks passed
@route
Copy link
Member

route commented May 10, 2024

Thanks!

@erickguan erickguan deleted the add-deps branch May 10, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants