fix: use token to login to docker hub (#163)

rudderlabs · Aug 8, 2024 · dbc7d14 · dbc7d14
1 parent 76e366b
commit dbc7d14
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/.github/workflows/pr-onto-dev.yaml b/.github/workflows/pr-onto-dev.yaml
@@ -21,7 +21,7 @@ jobs:
     #     tagFormat: v${version}
     #     failBuild: true
     - run: |
-        docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
+        docker login --username rudderlabs --password '${{ secrets.DOCKERHUB_TOKEN }}'
         export VERSION=${{ steps.branch-name.outputs.current_branch }}
         rm -rf rudder-alerta-enrichment-plugin
         git config --global url."https://${{secrets.PAT}}:x-oauth-basic@github.com/rudderlabs".insteadOf "https://github.com/rudderlabs"

diff --git a/.github/workflows/pr-onto-master.yaml b/.github/workflows/pr-onto-master.yaml
@@ -24,12 +24,3 @@ jobs:
         file: package.json
         tagFormat: v${version}
         failBuild: true
-    # - run: |
-    #     docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
-    #     export VERSION=${{ steps.branch-name.outputs.current_branch }}
-    #     rm -rf rudder-alerta-enrichment-plugin
-    #     git clone -b "$(cat RUDDER_ENRICH_PLUGIN_BRANCH_NAME)" git@github.com:rudderlabs/rudder-alerta-enrichment-plugin.git
-    #     docker build --no-cache --build-arg=COMMIT_ID_VALUE="$(git log --format="%H" -n 1)" -t rudderlabs/alerta:$VERSION .
-    #     docker push rudderlabs/alerta:$VERSION
-    #     rm -rf rudder-alerta-enrichment-plugin
-    #   name: Docker build and push
diff --git a/.github/workflows/push-onto-master.yaml b/.github/workflows/push-onto-master.yaml
@@ -26,7 +26,7 @@ jobs:
         failBuild: true
       id: version_check_staging
     - run: |
-        docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
+        docker login --username rudderlabs --password '${{ secrets.DOCKERHUB_TOKEN }}'
         export VERSION=${{steps.version_check_staging.outputs.releaseVersion}}
         rm -rf rudder-alerta-enrichment-plugin
         git config --global url."https://${{secrets.PAT}}:x-oauth-basic@github.com/rudderlabs".insteadOf "https://github.com/rudderlabs"