From dbc7d14c4d361cb618f5c5cf419be37d0de93986 Mon Sep 17 00:00:00 2001
From: Mihir Khambhati <39031445+itsmihir@users.noreply.github.com>
Date: Thu, 8 Aug 2024 13:41:36 +0530
Subject: [PATCH] fix: use token to login to docker hub (#163)

---
 .github/workflows/pr-onto-dev.yaml      | 2 +-
 .github/workflows/pr-onto-master.yaml   | 9 ---------
 .github/workflows/push-onto-master.yaml | 2 +-
 3 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/pr-onto-dev.yaml b/.github/workflows/pr-onto-dev.yaml
index fa36003e1..917530c35 100644
--- a/.github/workflows/pr-onto-dev.yaml
+++ b/.github/workflows/pr-onto-dev.yaml
@@ -21,7 +21,7 @@ jobs:
     #     tagFormat: v${version}
     #     failBuild: true
     - run: |
-        docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
+        docker login --username rudderlabs --password '${{ secrets.DOCKERHUB_TOKEN }}'
         export VERSION=${{ steps.branch-name.outputs.current_branch }}
         rm -rf rudder-alerta-enrichment-plugin
         git config --global url."https://${{secrets.PAT}}:x-oauth-basic@github.com/rudderlabs".insteadOf "https://github.com/rudderlabs"
diff --git a/.github/workflows/pr-onto-master.yaml b/.github/workflows/pr-onto-master.yaml
index 86f26a215..b4f7ee6d1 100644
--- a/.github/workflows/pr-onto-master.yaml
+++ b/.github/workflows/pr-onto-master.yaml
@@ -24,12 +24,3 @@ jobs:
         file: package.json
         tagFormat: v${version}
         failBuild: true
-    # - run: |
-    #     docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
-    #     export VERSION=${{ steps.branch-name.outputs.current_branch }}
-    #     rm -rf rudder-alerta-enrichment-plugin
-    #     git clone -b "$(cat RUDDER_ENRICH_PLUGIN_BRANCH_NAME)" git@github.com:rudderlabs/rudder-alerta-enrichment-plugin.git
-    #     docker build --no-cache --build-arg=COMMIT_ID_VALUE="$(git log --format="%H" -n 1)" -t rudderlabs/alerta:$VERSION .
-    #     docker push rudderlabs/alerta:$VERSION
-    #     rm -rf rudder-alerta-enrichment-plugin
-    #   name: Docker build and push
\ No newline at end of file
diff --git a/.github/workflows/push-onto-master.yaml b/.github/workflows/push-onto-master.yaml
index df7ec3232..0741a9860 100644
--- a/.github/workflows/push-onto-master.yaml
+++ b/.github/workflows/push-onto-master.yaml
@@ -26,7 +26,7 @@ jobs:
         failBuild: true
       id: version_check_staging
     - run: |
-        docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}'
+        docker login --username rudderlabs --password '${{ secrets.DOCKERHUB_TOKEN }}'
         export VERSION=${{steps.version_check_staging.outputs.releaseVersion}}
         rm -rf rudder-alerta-enrichment-plugin
         git config --global url."https://${{secrets.PAT}}:x-oauth-basic@github.com/rudderlabs".insteadOf "https://github.com/rudderlabs"