chore: include enrichment plugin code in alerta #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvrach
reviewed
Jul 31, 2024
| @@ -8,3 +8,4 @@ venv | |||
| .coverage | |||
| *.swp | |||
| *.log | |||
| .git | |||
There was a problem hiding this comment.
Suggested change
| .git | |
| **/.git |
Already fixed in the other PR
lvrach
reviewed
Jul 31, 2024
Comment on lines
17
to
20
| docker login --username rudderlabs --password '${{ secrets.DOCKER_HUB_PASSWORD }}' | ||
| export VERSION=${{ steps.branch-name.outputs.current_branch }} | ||
| rm -rf rudder-alerta-enrichment-plugin | ||
| git clone -b "$(cat RUDDER_ENRICH_PLUGIN_BRANCH_NAME)" https://${{ secrets.PAT_USERNAME }}:${{ secrets.PAT }}@github.com/rudderlabs/rudder-alerta-enrichment-plugin.git | ||
| docker build --no-cache --build-arg=COMMIT_ID_VALUE="$(git log --format="%H" -n 1)" -t rudderlabs/alerta:$VERSION . | ||
| docker push rudderlabs/alerta:$VERSION |
There was a problem hiding this comment.
As a best practise we should also use https://github.com/docker/build-push-action
lvrach
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review