Skip to content

Commit

Permalink
Merge pull request #1013 from rudderlabs/hotfix-release/v1.56.1
Browse files Browse the repository at this point in the history
chore(release): pull hotfix-release/v1.56.1 into main
  • Loading branch information
aashishmalik authored Oct 25, 2023
2 parents 6c07d96 + d76ba26 commit 0c0d232
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 20 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.56.1](https://github.com/rudderlabs/rudder-config-schema/compare/v1.56.0...v1.56.1) (2023-10-25)


### Bug Fixes

* criteo audience audienceId schema fix ([#1012](https://github.com/rudderlabs/rudder-config-schema/issues/1012)) ([53ed5a5](https://github.com/rudderlabs/rudder-config-schema/commit/53ed5a5abf2d14439f2ef6bfa9f88492494a0c95))

## [1.56.0](https://github.com/rudderlabs/rudder-config-schema/compare/v1.55.2...v1.56.0) (2023-10-25)


Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rudder-config-schema",
"version": "1.56.0",
"version": "1.56.1",
"description": "",
"main": "src/index.ts",
"private": true,
Expand Down
9 changes: 0 additions & 9 deletions src/configurations/destinations/criteo_audience/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,6 @@
}
}
},
"audienceId": {
"type": "object",
"properties": {
"cloud": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$"
}
}
},
"audienceType": {
"type": "string",
"enum": ["email", "madid", "identityLink", "gum"],
Expand Down
11 changes: 3 additions & 8 deletions test/data/validation/destinations/criteo_audience.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@
"audienceType": "email",
"adAccountId": { "warehouse": "4343434" }
},
"result": false,
"err": [
"audienceId.cloud must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$\""
]
"result": true
},
{
"config": {
Expand All @@ -39,8 +36,7 @@
"err": [
"gumCallerId must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$\"",
" must match \"then\" schema",
" must match a schema in anyOf",
"audienceId must be object"
" must match a schema in anyOf"
]
},
{
Expand All @@ -49,7 +45,6 @@
"audienceType": "gum",
"gumCallerId": "14245"
},
"result": false,
"err": ["audienceId must be object"]
"result": true
}
]

0 comments on commit 0c0d232

Please sign in to comment.