From 53ed5a5abf2d14439f2ef6bfa9f88492494a0c95 Mon Sep 17 00:00:00 2001 From: AASHISH MALIK Date: Wed, 25 Oct 2023 16:34:55 +0530 Subject: [PATCH 1/2] fix: criteo audience audienceId schema fix (#1012) --- .../destinations/criteo_audience/schema.json | 9 --------- .../data/validation/destinations/criteo_audience.json | 11 +++-------- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/src/configurations/destinations/criteo_audience/schema.json b/src/configurations/destinations/criteo_audience/schema.json index 4d3fabeec..48b11f8cd 100644 --- a/src/configurations/destinations/criteo_audience/schema.json +++ b/src/configurations/destinations/criteo_audience/schema.json @@ -13,15 +13,6 @@ } } }, - "audienceId": { - "type": "object", - "properties": { - "cloud": { - "type": "string", - "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$" - } - } - }, "audienceType": { "type": "string", "enum": ["email", "madid", "identityLink", "gum"], diff --git a/test/data/validation/destinations/criteo_audience.json b/test/data/validation/destinations/criteo_audience.json index ff36357d8..e9c28bf90 100644 --- a/test/data/validation/destinations/criteo_audience.json +++ b/test/data/validation/destinations/criteo_audience.json @@ -13,10 +13,7 @@ "audienceType": "email", "adAccountId": { "warehouse": "4343434" } }, - "result": false, - "err": [ - "audienceId.cloud must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$\"" - ] + "result": true }, { "config": { @@ -39,8 +36,7 @@ "err": [ "gumCallerId must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^[0-9]+$\"", " must match \"then\" schema", - " must match a schema in anyOf", - "audienceId must be object" + " must match a schema in anyOf" ] }, { @@ -49,7 +45,6 @@ "audienceType": "gum", "gumCallerId": "14245" }, - "result": false, - "err": ["audienceId must be object"] + "result": true } ] From d76ba26e279eee9a61339f54b2d56c8c46a7e14d Mon Sep 17 00:00:00 2001 From: GitHub Actions Date: Wed, 25 Oct 2023 11:07:28 +0000 Subject: [PATCH 2/2] chore(release): 1.56.1 --- CHANGELOG.md | 7 +++++++ package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d699e7372..a9c0ce606 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### [1.56.1](https://github.com/rudderlabs/rudder-config-schema/compare/v1.56.0...v1.56.1) (2023-10-25) + + +### Bug Fixes + +* criteo audience audienceId schema fix ([#1012](https://github.com/rudderlabs/rudder-config-schema/issues/1012)) ([53ed5a5](https://github.com/rudderlabs/rudder-config-schema/commit/53ed5a5abf2d14439f2ef6bfa9f88492494a0c95)) + ## [1.56.0](https://github.com/rudderlabs/rudder-config-schema/compare/v1.55.2...v1.56.0) (2023-10-25) diff --git a/package-lock.json b/package-lock.json index 564ba5f1c..2d667c082 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "rudder-config-schema", - "version": "1.56.0", + "version": "1.56.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "rudder-config-schema", - "version": "1.56.0", + "version": "1.56.1", "license": "MIT", "dependencies": { "ajv": "^8.12.0", diff --git a/package.json b/package.json index 56721f6a9..c8a7ebb1a 100755 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "rudder-config-schema", - "version": "1.56.0", + "version": "1.56.1", "description": "", "main": "src/index.ts", "private": true,