From 11ad344e12b3276faf4797c9ab44e5f3bc436e13 Mon Sep 17 00:00:00 2001 From: AASHISH MALIK Date: Wed, 6 Nov 2024 23:12:00 +0530 Subject: [PATCH] fix: gaec schema --- .../schema.json | 2 +- .../google_adwords_enhanced_conversions.json | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json b/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json index 95586112f..0dc9befe1 100644 --- a/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json +++ b/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json @@ -3,7 +3,7 @@ "$schema": "http://json-schema.org/draft-07/schema#", "type": "object", "required": ["configData"], - "additionalProperties": false, + "additionalProperties": true, "properties": { "configData": { "type": "string", diff --git a/test/data/validation/destinations/google_adwords_enhanced_conversions.json b/test/data/validation/destinations/google_adwords_enhanced_conversions.json index a1682e164..d3881206d 100644 --- a/test/data/validation/destinations/google_adwords_enhanced_conversions.json +++ b/test/data/validation/destinations/google_adwords_enhanced_conversions.json @@ -220,5 +220,21 @@ "ketchConsentPurposes.unity.0 must be object" ], "result": false + }, + { + "config": { + "rudderAccountId": "3454354534", + "listOfConversions": [ + { + "conversions": "Page View" + }, + { + "conversions": "Product Added" + } + ], + "authStatus": "active", + "configData": "{\"customerId\": \"1234567890\", \"loginCustomerId\": \"\"}" + }, + "result": true } ]