Skip to content

Commit

Permalink
chore(release): pull hotfix-release/v1.45.1 into main (#834)
Browse files Browse the repository at this point in the history
Co-authored-by: shrouti1507 <60211312+shrouti1507@users.noreply.github.com>
Co-authored-by: Mihir Bhalala <77438541+mihir-4116@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
  • Loading branch information
4 people authored Aug 16, 2023
1 parent 6fe1251 commit 27d6b64
Show file tree
Hide file tree
Showing 8 changed files with 88 additions and 64 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.45.1](https://github.com/rudderlabs/rudder-config-schema/compare/v1.45.0...v1.45.1) (2023-08-16)


### Bug Fixes

* **dcmfloodlight:** schema issue ([#833](https://github.com/rudderlabs/rudder-config-schema/issues/833)) ([9f8cede](https://github.com/rudderlabs/rudder-config-schema/commit/9f8cede260f4fd9619609a7fdc6e1500d20d6fc6))
* make bingAds aud visible and add message type to marketo bulk upload ([#832](https://github.com/rudderlabs/rudder-config-schema/issues/832)) ([e8b0435](https://github.com/rudderlabs/rudder-config-schema/commit/e8b0435aae6b71d59e977ce8e56762a5e3ae0e18))

## [1.45.0](https://github.com/rudderlabs/rudder-config-schema/compare/v1.44.2...v1.45.0) (2023-08-14)


Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rudder-config-schema",
"version": "1.45.0",
"version": "1.45.1",
"description": "",
"main": "src/index.ts",
"private": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,5 @@
]
}
},
"options": {
"hidden": true
}
"options": { "isBeta": true }
}
91 changes: 69 additions & 22 deletions src/configurations/destinations/dcm_floodlight/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
"configSchema": {
"$schema": "http://json-schema.org/draft-07/schema#",
"type": "object",
"required": ["advertiserId"],
"required": [
"advertiserId"
],
"properties": {
"advertiserId": {
"type": "string",
Expand Down Expand Up @@ -33,7 +35,10 @@
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"salesTag": { "type": "boolean" },
"salesTag": {
"type": "boolean",
"default": false
},
"customVariables": {
"type": "array",
"items": {
Expand All @@ -45,17 +50,76 @@
},
"to": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^([0-9]{0,100})$"
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
}
}
}
},
"useNativeSDK": {
"type": "object",
"properties": {
"web": {
"type": "boolean"
}
}
},
"tagFormat": {
"type": "object",
"properties": {
"web": {
"type": "string",
"enum": [
"globalSiteTag",
"iframeTag"
],
"default": "globalSiteTag"
}
}
},
"conversionLinker": {
"type": "object",
"properties": {
"web": {
"type": "boolean"
}
}
},
"allowAdPersonalizationSignals": {
"type": "object",
"properties": {
"web": {
"type": "boolean"
}
}
},
"doubleclickId": {
"type": "object",
"properties": {
"web": {
"type": "boolean"
}
}
},
"googleNetworkId": {
"type": "object",
"properties": {
"web": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
},
"eventFilteringOption": {
"type": "string",
"pattern": "(^env[.].+)|^(disable|whitelistedEvents|blacklistedEvents)$"
"enum": [
"disable",
"whitelistedEvents",
"blacklistedEvents"
],
"default": "disable"
},
"whitelistedEvents": {
"type": "array",
Expand All @@ -81,23 +145,6 @@
}
}
},
"useNativeSDK": { "type": "object", "properties": { "web": { "type": "boolean" } } },
"tagFormat": { "type": "string", "pattern": "(^env[.].+)|^(globalSiteTag|iframeTag)$" },
"conversionLinker": { "type": "object", "properties": { "web": { "type": "boolean" } } },
"allowAdPersonalizationSignals": {
"type": "object",
"properties": { "web": { "type": "boolean" } }
},
"doubleclickId": { "type": "object", "properties": { "web": { "type": "boolean" } } },
"googleNetworkId": {
"type": "object",
"properties": {
"web": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
},
"oneTrustCookieCategories": {
"type": "array",
"items": {
Expand All @@ -112,4 +159,4 @@
}
}
}
}
}
8 changes: 4 additions & 4 deletions src/configurations/destinations/dcm_floodlight/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"type": "textInput",
"label": "Activity Tag",
"value": "activityTag",
"regex": ".*",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$",
"required": false,
"placeholder": "e.g. signu0",
"secret": false,
Expand All @@ -27,7 +27,7 @@
"type": "textInput",
"label": "Group Tag",
"value": "groupTag",
"regex": ".*",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$",
"required": false,
"placeholder": "e.g. conv01",
"secret": false,
Expand Down Expand Up @@ -136,7 +136,7 @@
"type": "textInput",
"label": "Google Network Id",
"value": "googleNetworkId",
"regex": ".*",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$",
"required": false,
"footerNote": "Network ID (NID) for the bidder account"
}
Expand Down Expand Up @@ -217,4 +217,4 @@
]
}
]
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"warehouse",
"shopify"
],
"supportedMessageTypes": ["identify"],
"destConfig": {
"defaultConfig": [
"clientId",
Expand Down
34 changes: 2 additions & 32 deletions test/data/validation/destinations/dcm_floodlight.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,36 +26,6 @@
},
"result": true
},
{
"config": {
"advertiserId": "22448662",
"activityTag": "",
"groupTag": "",
"conversionEvents": [
{
"eventName": "Product viewed",
"floodlightActivityTag": "signu01",
"floodlightGroupTag": "conv01",
"salesTag": false,
"customVariables": [
{ "from": "RudderstackProperty1", "to": "u1" },
{ "from": "RudderstackProperty2", "to": "2" }
]
},
{
"eventName": "Order Complete",
"floodlightActivityTag": "signu01",
"floodlightGroupTag": "conv02",
"salesTag": false,
"customVariables": [{ "from": "", "to": "" }]
}
]
},
"result": false,
"err": [
"conversionEvents.0.customVariables.0.to must match pattern \"(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^([0-9]{0,100})$\""
]
},
{
"config": {
"advertiserId": "12AUXUS123",
Expand Down Expand Up @@ -116,7 +86,7 @@
"useNativeSDK": { "web": true },
"conversionLinker": { "web": true },
"allowAdPersonalizationSignals": { "web": true },
"tagFormat": "globalSiteTag",
"tagFormat": {"web": "globalSiteTag"},
"doubleclickId": { "web": true },
"googleNetworkId": { "web": "1234" },
"oneTrustCookieCategories": [{ "oneTrustCookieCategory": "" }]
Expand Down Expand Up @@ -153,7 +123,7 @@
"useNativeSDK": { "web": false },
"conversionLinker": { "web": true },
"allowAdPersonalizationSignals": { "web": true },
"tagFormat": "iframeTag",
"tagFormat": {"web": "iframeTag"},
"doubleclickId": { "web": false },
"googleNetworkId": { "web": "1234" },
"oneTrustCookieCategories": [{ "oneTrustCookieCategory": "" }]
Expand Down

0 comments on commit 27d6b64

Please sign in to comment.