feat: gaec migration

rudderlabs · Nov 5, 2024 · 5c8ea3a · 5c8ea3a
1 parent 300f547
commit 5c8ea3a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 28 deletions.
diff --git a/src/configurations/destinations/google_adwords_enhanced_conversions/db-config.json b/src/configurations/destinations/google_adwords_enhanced_conversions/db-config.json
@@ -44,11 +44,9 @@
     "destConfig": {
       "defaultConfig": [
         "rudderAccountId",
-        "customerId",
         "listOfConversions",
-        "subAccount",
-        "loginCustomerId",
-        "requireHash"
+        "requireHash",
+        "configData"
       ],
       "android": [
         "connectionMode",

diff --git a/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json b/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json
@@ -3,6 +3,10 @@
     "$schema": "http://json-schema.org/draft-07/schema#",
     "type": "object",
     "properties": {
+      "configData": {
+        "type": "string",
+        "default": "{\"customerId\": \"123\"}"
+      },
       "oneTrustCookieCategories": {
         "type": "object",
         "properties": {

diff --git a/src/configurations/destinations/google_adwords_enhanced_conversions/ui-config.json b/src/configurations/destinations/google_adwords_enhanced_conversions/ui-config.json
@@ -13,35 +13,22 @@
                 "icon": "settings",
                 "fields": [
                   {
-                    "type": "textInput",
-                    "label": "Customer ID",
-                    "note": "Enter the Customer ID",
-                    "configKey": "customerId",
-                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$",
-                    "regexErrorMessage": "Invalid Customer Id",
-                    "placeholder": "e.g: 9693XX9833"
-                  },
-                  {
-                    "type": "checkbox",
-                    "label": "Sub Account",
-                    "configKey": "subAccount",
-                    "default": false
-                  },
-                  {
-                    "type": "textInput",
-                    "label": "Login Customer ID",
-                    "note": "Enter the Login Customer ID",
-                    "configKey": "loginCustomerId",
-                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$",
-                    "regexErrorMessage": "Invalid Login Customer Id",
+                    "type": "nestedSelect",
+                    "label": "Select account",
+                    "apiName": "getConfigData",
+                    "configKey": "configData",
+                    "placeholder": "Select account details",
                     "preRequisites": {
                       "fields": [
                         {
-                          "configKey": "subAccount",
-                          "value": true
+                          "exists": true,
+                          "configKey": "rudderAccountId"
                         }
                       ]
-                    }
+                    },
+                    "apiDependencies": [
+                      "rudderAccountId"
+                    ]
                   }
                 ]
               }