Skip to content

Commit

Permalink
Merge branch 'develop' into chore.unused.sdk.param.cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
yashasvibajpai authored Jul 25, 2023
2 parents 2731418 + 97b6b8f commit 678b858
Show file tree
Hide file tree
Showing 123 changed files with 2,772 additions and 1,666 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [1.42.2](https://github.com/rudderlabs/rudder-config-schema/compare/v1.42.1...v1.42.2) (2023-07-19)

### [1.42.1](https://github.com/rudderlabs/rudder-config-schema/compare/v1.42.0...v1.42.1) (2023-07-14)


Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rudder-config-schema",
"version": "1.42.1",
"version": "1.42.2",
"description": "",
"main": "src/index.ts",
"private": true,
Expand Down
5 changes: 4 additions & 1 deletion scripts/schemaGenerator.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@

CONFIG_DIR = 'src/configurations'

EXCLUDED_DEST = ['postgres']

class FieldTypeEnum(Enum):
STRING = "string"
OBJECT = "object"
Expand Down Expand Up @@ -1002,7 +1004,8 @@ def get_schema_diff(name, selector):
uiConfig = file_content.get("uiConfig")
schema = file_content.get("configSchema")
dbConfig = file_content.get("config")
validate_config_consistency(name, selector, uiConfig, dbConfig, schema)
if name not in EXCLUDED_DEST:
validate_config_consistency(name, selector, uiConfig, dbConfig, schema)


if __name__ == '__main__':
Expand Down
14 changes: 10 additions & 4 deletions src/configurations/destinations/adobe_analytics/db-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
"blacklistedEvents",
"whitelistedEvents",
"oneTrustCookieCategories",
"eventFilteringOption"
"eventFilteringOption",
"connectionMode"
],
"excludeKeys": [],
"supportedSourceTypes": [
Expand All @@ -52,6 +53,11 @@
"flutter",
"cordova"
],
"supportedConnectionModes": {
"web": ["cloud", "device"],
"android": ["cloud", "device"],
"ios": ["cloud", "device"]
},
"destConfig": {
"defaultConfig": [
"trackingServerUrl",
Expand Down Expand Up @@ -90,9 +96,9 @@
"eventFilteringOption",
"oneTrustCookieCategories"
],
"web": ["useNativeSDK"],
"android": ["useNativeSDK"],
"ios": ["useNativeSDK"]
"web": ["useNativeSDK", "connectionMode"],
"android": ["useNativeSDK", "connectionMode"],
"ios": ["useNativeSDK", "connectionMode"]
}
}
}
38 changes: 11 additions & 27 deletions src/configurations/destinations/adobe_analytics/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,20 +176,8 @@
"to": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
},
"listDelimiter": {
"type": "array",
"items": {
"type": "object",
"properties": {
"from": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"to": { "type": "string", "enum": ["|", ":", ",", ";", "/", ""] }
"delimiter": { "type": "string", "enum": ["|", ":", ",", ";", "/", ""] }
}
}
},
Expand All @@ -205,20 +193,8 @@
"to": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
}
}
}
},
"propsDelimiter": {
"type": "array",
"items": {
"type": "object",
"properties": {
"from": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"to": { "type": "string", "enum": ["|", ":", ",", ";", "/", ""] }
"delimiter": { "type": "string", "enum": ["|", ":", ",", ";", "/", ""] }
}
}
},
Expand Down Expand Up @@ -303,6 +279,14 @@
"web": { "type": "boolean" }
}
},
"connectionMode": {
"type": "object",
"properties": {
"android": { "type": "string", "enum": ["cloud", "device"] },
"ios": { "type": "string", "enum": ["cloud", "device"] },
"web": { "type": "string", "enum": ["cloud", "device"] }
}
},
"eventFilteringOption": {
"type": "string",
"enum": ["disable", "whitelistedEvents", "blacklistedEvents"],
Expand Down Expand Up @@ -345,6 +329,6 @@
}
}
},
"additionalProperties": false
"additionalProperties": true
}
}
Loading

0 comments on commit 678b858

Please sign in to comment.