Skip to content

Commit

Permalink
Merge pull request #826 from rudderlabs/hotfix-release/v1.45.0
Browse files Browse the repository at this point in the history
chore(release): pull hotfix-release/v1.45.0 into main
  • Loading branch information
aashishmalik authored Aug 14, 2023
2 parents fe4484b + 6910615 commit 6fe1251
Show file tree
Hide file tree
Showing 7 changed files with 52 additions and 9 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

## [1.45.0](https://github.com/rudderlabs/rudder-config-schema/compare/v1.44.2...v1.45.0) (2023-08-14)


### Features

* **zendesk:** add source name setting ([#825](https://github.com/rudderlabs/rudder-config-schema/issues/825)) ([51329cc](https://github.com/rudderlabs/rudder-config-schema/commit/51329ccdfcc97d3f0b0f99be76acb99ef4270b43))

### [1.44.2](https://github.com/rudderlabs/rudder-config-schema/compare/v1.44.1...v1.44.2) (2023-08-11)


Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rudder-config-schema",
"version": "1.44.2",
"version": "1.45.0",
"description": "",
"main": "src/index.ts",
"private": true,
Expand Down
3 changes: 2 additions & 1 deletion src/configurations/destinations/zendesk/db-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"sendGroupCallsWithoutUserId",
"removeUsersFromOrganization",
"searchByExternalId",
"oneTrustCookieCategories"
"oneTrustCookieCategories",
"sourceName"
]
},
"secretKeys": ["apiToken"]
Expand Down
20 changes: 16 additions & 4 deletions src/configurations/destinations/zendesk/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,22 @@
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"createUsersAsVerified": { "type": "boolean" },
"sendGroupCallsWithoutUserId": { "type": "boolean" },
"removeUsersFromOrganization": { "type": "boolean" },
"searchByExternalId": { "type": "boolean" },
"sourceName": {
"type": "string",
"pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
},
"createUsersAsVerified": {
"type": "boolean"
},
"sendGroupCallsWithoutUserId": {
"type": "boolean"
},
"removeUsersFromOrganization": {
"type": "boolean"
},
"searchByExternalId": {
"type": "boolean"
},
"oneTrustCookieCategories": {
"type": "array",
"items": {
Expand Down
10 changes: 10 additions & 0 deletions src/configurations/destinations/zendesk/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@
"required": true,
"placeholder": "Subdomain only not including .zendesk.com"
},
{
"type": "textInput",
"label": "Source Name",
"value": "sourceName",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$",
"regexErrorMessage": "Invalid Source",
"required": false,
"placeholder": "e.g: Rudder",
"footerNote": "Specify the source for the events. If not specified, the source is set to `Rudder` by default."
},
{
"type": "checkbox",
"label": "Create users as verified",
Expand Down
15 changes: 14 additions & 1 deletion test/data/validation/destinations/zendesk.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,20 @@
"domain": "coover",
"createUsersAsVerified": true,
"sendGroupCallsWithoutUserId": false,
"removeUsersFromOrganization": false
"removeUsersFromOrganization": false,
"sourceName": "abc"
},
"result": true
},
{
"config": {
"email": "rodrigo@coover.me",
"apiToken": "WpUn4Q6xTqXwvKUGDVcbWY7HxmUoOdEBvKIIOKP3",
"domain": "coover",
"createUsersAsVerified": true,
"sendGroupCallsWithoutUserId": false,
"removeUsersFromOrganization": false,
"sourceName": ""
},
"result": true
},
Expand Down

0 comments on commit 6fe1251

Please sign in to comment.