Merge pull request #1320 from rudderlabs/feat.add-ga4-custom-domain-f…

…ield feat: added custom domain input field during ga4 setup
rudderlabs · Apr 24, 2024 · c130057 · c130057
2 parents a529b03 + e32579f
commit c130057
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 3 deletions.
diff --git a/src/configurations/destinations/ga4/db-config.json b/src/configurations/destinations/ga4/db-config.json
@@ -18,7 +18,8 @@
       "overrideClientAndSessionId",
       "oneTrustCookieCategories",
       "ketchConsentPurposes",
-      "consentManagement"
+      "consentManagement",
+      "sdkBaseUrl"
     ],
     "excludeKeys": [],
     "supportedSourceTypes": [
@@ -68,7 +69,8 @@
         "eventFilteringOption",
         "piiPropertiesToIgnore",
         "oneTrustCookieCategories",
-        "ketchConsentPurposes"
+        "ketchConsentPurposes",
+        "sdkBaseUrl"
       ],
       "web": [
         "debugView",

diff --git a/src/configurations/destinations/ga4/schema.json b/src/configurations/destinations/ga4/schema.json
@@ -557,7 +557,28 @@
               "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(G-.{1,100})$|^$"
             }
           },
-          "required": ["measurementId"]
+          "required": ["measurementId"],
+          "allOf": [
+            {
+              "if": {
+                "properties": {
+                  "connectionMode": {
+                    "type": "object",
+                    "properties": { "web": { "type": "string", "enum": ["device"] } }
+                  }
+                },
+                "required": ["connectionMode"]
+              },
+              "then": {
+                "properties": {
+                  "sdkBaseUrl": {
+                    "type": "string",
+                    "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$"
+                  }
+                }
+              }
+            }
+          ]
         }
       },
       {

diff --git a/src/configurations/destinations/ga4/ui-config.json b/src/configurations/destinations/ga4/ui-config.json
@@ -38,6 +38,29 @@
                     ],
                     "default": "gtag"
                   },
+                  {
+                    "type": "textInput",
+                    "preRequisites": {
+                      "fields": [
+                        {
+                          "configKey": "typesOfClient",
+                          "value": "gtag"
+                        },
+                        {
+                          "configKey": "connectionMode.web",
+                          "value": "device"
+                        }
+                      ]
+                    },
+                    "label": "SDK Base URL",
+                    "configKey": "sdkBaseUrl",
+                    "regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$",
+                    "regexErrorMessage": "Please input a valid URL.",
+                    "note": "Enter your GA4 SDK base URL, https://{SDK Base URL}/gtag/js. By default, it is https://www.googletagmanager.com.",
+                    "placeholder": "e.g: https://www.example.com",
+                    "default": "https://www.googletagmanager.com",
+                    "secret": false
+                  },
                   {
                     "type": "textInput",
                     "preRequisites": {

diff --git a/test/data/validation/destinations/ga4.json b/test/data/validation/destinations/ga4.json
@@ -45,6 +45,7 @@
       "apiSecret": "QyWIGHj8QhG2L4ePAPiXCA",
       "typesOfClient": "gtag",
       "measurementId": "F40RN6STS2",
+      "sdkBaseUrl": "https://www.example.com",
       "firebaseAppId": "",
       "capturePageView": {
         "web": "rs"