Skip to content

Commit

Permalink
Revert "feat: bq configurable partitions (#1630)"
Browse files Browse the repository at this point in the history
This reverts commit a7e21e5.
  • Loading branch information
achettyiitr committed Oct 1, 2024
1 parent a7fc6b1 commit e457a60
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 127 deletions.
4 changes: 1 addition & 3 deletions src/configurations/destinations/bq/db-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
"skipUsersTable",
"jsonPaths",
"underscoreDivideNumbers",
"allowUsersContextTraits",
"partitionColumn",
"partitionType"
"allowUsersContextTraits"
],
"android": [
"connectionMode",
Expand Down
10 changes: 0 additions & 10 deletions src/configurations/destinations/bq/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,6 @@
"pattern": "^(5|15|30|60|180|360|720|1440)$",
"default": "180"
},
"partitionColumn": {
"type": "string",
"pattern": "^(_PARTITIONTIME|loaded_at|received_at)$",
"default": "_PARTITIONTIME"
},
"partitionType": {
"type": "string",
"pattern": "^(hour|day)$",
"default": "day"
},
"syncStartAt": {
"type": "string"
},
Expand Down
46 changes: 0 additions & 46 deletions src/configurations/destinations/bq/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -142,52 +142,6 @@
},
"required": false,
"footerNote": "Note: Please specify time in UTC"
},
{
"type": "singleSelect",
"immutable": true,
"label": "Partition Column",
"value": "partitionColumn",
"options": [
{
"name": "Ingestion Time",
"value": "_PARTITIONTIME"
},
{
"name": "Loaded At",
"value": "loaded_at"
},
{
"name": "Received At",
"value": "received_at"
}
],
"defaultOption": {
"name": "Ingestion Time",
"value": "_PARTITIONTIME"
},
"required": false
},
{
"type": "singleSelect",
"immutable": true,
"label": "Partition Type",
"value": "partitionType",
"options": [
{
"name": "Hour",
"value": "hour"
},
{
"name": "Day",
"value": "day"
}
],
"defaultOption": {
"name": "Day",
"value": "day"
},
"required": false
}
]
},
Expand Down
68 changes: 0 additions & 68 deletions test/data/validation/destinations/bq.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,74 +13,6 @@
},
"result": true
},
{
"config": {
"project": "test-gcs-project",
"location": "",
"bucketName": "test-bucket",
"prefix": "xyzxx",
"namespace": "eu_new3",
"partitionColumn": "_PARTITIONTIME",
"partitionType": "day",
"credentials": "{}",
"syncFrequency": "30",
"testConnection": false,
"testConnectionTS": 1621402528550
},
"result": true
},
{
"config": {
"project": "test-gcs-project",
"location": "",
"bucketName": "test-bucket",
"prefix": "xyzxx",
"namespace": "eu_new3",
"partitionColumn": "received_at",
"partitionType": "hour",
"credentials": "{}",
"syncFrequency": "30",
"testConnection": false,
"testConnectionTS": 1621402528550
},
"result": true
},
{
"config": {
"project": "test-gcs-project",
"location": "",
"bucketName": "test-bucket",
"prefix": "xyzxx",
"namespace": "eu_new3",
"partitionColumn": "invalid",
"partitionType": "day",
"credentials": "{}",
"syncFrequency": "30",
"testConnection": false,
"testConnectionTS": 1621402528550
},
"result": false,
"error": [
"partitionColumn must match pattern \"^(_PARTITIONTIME|loaded_at|received_at|timestamp)$\""
]
},
{
"config": {
"project": "test-gcs-project",
"location": "",
"bucketName": "test-bucket",
"prefix": "xyzxx",
"namespace": "eu_new3",
"partitionColumn": "_PARTITIONTIME",
"partitionType": "invalid",
"credentials": "{}",
"syncFrequency": "30",
"testConnection": false,
"testConnectionTS": 1621402528550
},
"result": false,
"error": ["partitionType must match pattern \"^(hour|day|month|year)$\""]
},
{
"config": {
"project": "test-gcs-project",
Expand Down

0 comments on commit e457a60

Please sign in to comment.