Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove supportedMessageTypes for webhook #1102

Closed
wants to merge 1 commit into from

Conversation

ujjwal-ab
Copy link
Contributor

Description of the change

  • Remove supportedMessageTypes for webhook destination

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • I have executed schemaGenerator tests and updated schema if needed

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b54ba6d) 100.00% compared to head (4548721) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krishna2020 krishna2020 closed this Dec 7, 2023
@krishna2020
Copy link
Collaborator

creating PR via release branch

@ujjwal-ab ujjwal-ab deleted the hotfix/webhook-messageType branch December 7, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants