chore(release): pull release/v1.65.0 into main #1221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore(release): pull main into develop post release v1.64.0
chore(release): pull main into develop post release v1.64.1
chore(release): pull main into develop post release v1.64.2
devops-github-rudderstack
requested review from
lvrach,
cisse21,
nidhilashkari17,
debanjan97,
ssbeefeater,
AchuthaSourabhC,
ruchiramoitra,
ashishRudder,
ItsSudip,
shrouti1507 and
sandeepdsvs
as code owners
devops-github-rudderstack
requested review from
krishna2020,
desusai7,
1abhishekpandey and
bardisg
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
shrouti1507
previously approved these changes
Feb 19, 2024
INT-1621 Integrations Config Release (20 February, 2024)
Issues
PRs [Link Release & Deployment PR's here] Version Updates
Docker Image No Image, this service deals only with configuration changes Security Assessment [Review if sensitive fields are marked as |
krishna2020
reviewed
Feb 20, 2024
| ### Features | ||
|
|
||
| * add connectionMode for all sourceTypes in dest def for selected destinations ([#1197](https://github.com/rudderlabs/rudder-config-schema/issues/1197)) ([dde686c](https://github.com/rudderlabs/rudder-config-schema/commit/dde686cc72e0ac7423487d566e8f9715cc43d24f)) | ||
| * adding custom field support for freshsales ([#1195](https://github.com/rudderlabs/rudder-config-schema/issues/1195)) ([9124fb4](https://github.com/rudderlabs/rudder-config-schema/commit/9124fb44fd18d903bbf37f7cef3eaf7aeccf92e4)) |
There was a problem hiding this comment.
@shrouti1507 clean it up here too
|
|
||
| * add support of placing properties at root in af ([#1203](https://github.com/rudderlabs/rudder-config-schema/issues/1203)) ([1859354](https://github.com/rudderlabs/rudder-config-schema/commit/185935467899222b8766c63c63b934d70410cc9a)) | ||
| * comscore schema ([#1217](https://github.com/rudderlabs/rudder-config-schema/issues/1217)) ([7faa64a](https://github.com/rudderlabs/rudder-config-schema/commit/7faa64acfe2fca20b75789f31b541dd33e7fde8c)) | ||
| * reverting unhide of salesforce oauth ([#1220](https://github.com/rudderlabs/rudder-config-schema/issues/1220)) ([e73981f](https://github.com/rudderlabs/rudder-config-schema/commit/e73981f54b757aa60181942a19e7db97aac40658)) |
There was a problem hiding this comment.
@shrouti1507 don't see any corresponding file changes for salesforce_oauth in PR
There was a problem hiding this comment.
By mistake I unhide the salesforce oauth, so hid it again. Would need a clean up in changelog. Raising a new PR
| "cdkV2Enabled": true, | ||
| "transformAtV1": "processor", | ||
| "saveDestinationResponse": true, | ||
| "includeKeys": ["oneTrustCookieCategories"], |
There was a problem hiding this comment.
when there's no device mode, shouldn't includeKeys be empty array ?
| "defaultConfig": ["bluecoreNamespace", "eventsMapping", "oneTrustCookieCategories"] | ||
| }, | ||
| "secretKeys": ["bluecoreNamespace"] | ||
| } |
There was a problem hiding this comment.
Initial release should always be beta, add in option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR
Resolves INT-1621