-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): pull release/v1.74.0 into main #1363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: onboard new destination sftp
chore(release): pull main into develop post release v1.72.0
…1301) Co-authored-by: Sai Sankeerth <sanpj2292@github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
devops-github-rudderstack
requested review from
lvrach,
cisse21,
debanjan97,
am6010,
ssbeefeater,
AchuthaSourabhC,
ruchiramoitra,
ItsSudip,
shrouti1507,
sandeepdsvs,
krishna2020,
1abhishekpandey and
RanjeetMishra
as code owners
May 13, 2024 10:01
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 53 53
Branches 7 7
=========================================
Hits 53 53 ☔ View full report in Codecov by Sentry. |
chore(release): pull main into develop post release v1.73.0
…onfig into release/v1.74.0
krishna2020
reviewed
May 15, 2024
krishna2020
reviewed
May 15, 2024
src/configurations/destinations/fb_custom_audience/db-config.json
Outdated
Show resolved
Hide resolved
This reverts commit 9f301a4.
…b_custom Revert "feat: app secret support for facebook custom audience"
fix: add unity and web as supported source type on singular
am6010
previously approved these changes
May 15, 2024
Co-authored-by: Krishna Chaitanya <chaithu.kitti@gmail.com>
krishna2020
approved these changes
May 16, 2024
ItsSudip
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👑 An automated PR