Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bq configurable partitions #1630

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Aug 25, 2024

What are the changes introduced in this PR?

  • Support for BigQuery custom partitioning. This required the addition of two immutable fields [partitionColumn and partitionType]

What is the related Linear task?

  • Resolves PIPE-1352

Please explain the objectives of your changes below

  • Ability to choose partition for BigQuery tables.

Developer checklist

  • My code follows the style guidelines of this project
  • No breaking changes are being introduced.
  • All related docs linked with the PR?
  • All changes manually tested?
  • Any documentation changes needed with this change?
  • I have executed schemaGenerator tests and updated schema if needed
  • Are sensitive fields marked as secret in definition config?
  • My test cases and placeholders use only masked/sample values for sensitive fields
  • Is the PR limited to 10 file changes & one task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?
  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6ac3dd6) to head (41e28b2).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1630   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr
Copy link
Member Author

achettyiitr commented Sep 16, 2024

  • Dropdown Partition Column

    • Screenshot 2024-09-30 at 11 45 07 AM
  • Dropdown Partition Type

    • Screenshot 2024-09-30 at 11 45 13 AM
    • Screenshot 2024-09-30 at 11 42 17 AM

@achettyiitr achettyiitr marked this pull request as draft September 17, 2024 22:46
@achettyiitr achettyiitr marked this pull request as ready for review September 18, 2024 19:47
@achettyiitr achettyiitr changed the title feat: support for bq custom partitioning feat: bq configurable partitions Sep 24, 2024
@ktgowtham ktgowtham self-requested a review September 24, 2024 11:04
@achettyiitr achettyiitr merged commit a7e21e5 into develop Sep 30, 2024
10 checks passed
@achettyiitr achettyiitr deleted the feat.bq-custom-partition branch September 30, 2024 07:10
achettyiitr added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants