Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snowpipe streaming #1688

Merged
merged 4 commits into from
Oct 25, 2024
Merged

feat: snowpipe streaming #1688

merged 4 commits into from
Oct 25, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Sep 17, 2024

What are the changes introduced in this PR?

  • A new integration for Snowpipe Streaming has been added.
  • Resolves PIPE-1415

Developer checklist

  • My code follows the style guidelines of this project
  • No breaking changes are being introduced.
  • All related docs linked with the PR?
  • All changes manually tested?
  • Any documentation changes needed with this change?
  • I have executed schemaGenerator tests and updated schema if needed
  • Are sensitive fields marked as secret in definition config?
  • My test cases and placeholders use only masked/sample values for sensitive fields
  • Is the PR limited to 10 file changes & one task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?
  • Verified that there are no credentials or confidential data exposed with the changes.

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration file for Snowpipe Streaming, enhancing the setup process.
    • Added a JSON schema for validating Snowpipe streaming configurations to ensure proper setup.
    • Implemented a structured UI configuration for managing connection and consent settings effectively.
  • Tests

    • Added a suite of configuration test cases to validate account management and consent management configurations.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (70b81c3) to head (c839235).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1688   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr removed the DO NOT MERGE Approved but need to check more label Sep 23, 2024
@achettyiitr achettyiitr marked this pull request as draft September 23, 2024 19:33
@achettyiitr achettyiitr marked this pull request as ready for review October 19, 2024 06:24
coderabbitai[bot]

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

coderabbitai[bot]

This comment was marked as off-topic.

@achettyiitr achettyiitr force-pushed the feat.snowpipe-streaming branch 2 times, most recently from 70c0481 to 9cd46fa Compare October 19, 2024 14:47
@rudderlabs rudderlabs deleted a comment from coderabbitai bot Oct 19, 2024
@achettyiitr
Copy link
Member Author

achettyiitr commented Oct 21, 2024

Screenshot 2024-10-21 at 10 27 33 AM
Screenshot 2024-10-21 at 10 27 44 AM
Screenshot 2024-10-21 at 10 28 08 AM
Screenshot 2024-10-21 at 10 28 20 AM

coderabbitai[bot]

This comment was marked as off-topic.

@rudderlabs rudderlabs deleted a comment from coderabbitai bot Oct 23, 2024
@achettyiitr achettyiitr merged commit ae753c7 into develop Oct 25, 2024
11 checks passed
@achettyiitr achettyiitr deleted the feat.snowpipe-streaming branch October 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants