From d3129eac76e4eccbdc4d05d8cd3bb6f4d6a45697 Mon Sep 17 00:00:00 2001
From: AASHISH MALIK <imashishmalik.45@gmail.com>
Date: Wed, 6 Nov 2024 23:12:00 +0530
Subject: [PATCH] fix: gaec schema

---
 .../schema.json                                  |  2 +-
 .../destinations/http/ui-config.json             |  4 ++--
 .../google_adwords_enhanced_conversions.json     | 16 ++++++++++++++++
 3 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json b/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json
index 95586112f..0dc9befe1 100644
--- a/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json
+++ b/src/configurations/destinations/google_adwords_enhanced_conversions/schema.json
@@ -3,7 +3,7 @@
     "$schema": "http://json-schema.org/draft-07/schema#",
     "type": "object",
     "required": ["configData"],
-    "additionalProperties": false,
+    "additionalProperties": true,
     "properties": {
       "configData": {
         "type": "string",
diff --git a/src/configurations/destinations/http/ui-config.json b/src/configurations/destinations/http/ui-config.json
index 66292d7ff..0d6a5506d 100644
--- a/src/configurations/destinations/http/ui-config.json
+++ b/src/configurations/destinations/http/ui-config.json
@@ -565,7 +565,7 @@
                     "type": "textInput",
                     "key": "from",
                     "label": "Value",
-                    "placeholder": "e.g: $.userId"
+                    "placeholder": "e.g: $.userId or \"userId\""
                   }
                 ]
               }
@@ -592,7 +592,7 @@
                     "type": "textInput",
                     "key": "from",
                     "label": "Value",
-                    "placeholder": "e.g. application/json"
+                    "placeholder": "e.g. \"application/json\""
                   }
                 ]
               }
diff --git a/test/data/validation/destinations/google_adwords_enhanced_conversions.json b/test/data/validation/destinations/google_adwords_enhanced_conversions.json
index a1682e164..d3881206d 100644
--- a/test/data/validation/destinations/google_adwords_enhanced_conversions.json
+++ b/test/data/validation/destinations/google_adwords_enhanced_conversions.json
@@ -220,5 +220,21 @@
       "ketchConsentPurposes.unity.0 must be object"
     ],
     "result": false
+  },
+  {
+    "config": {
+      "rudderAccountId": "3454354534",
+      "listOfConversions": [
+        {
+          "conversions": "Page View"
+        },
+        {
+          "conversions": "Product Added"
+        }
+      ],
+      "authStatus": "active",
+      "configData": "{\"customerId\": \"1234567890\", \"loginCustomerId\": \"\"}"
+    },
+    "result": true
   }
 ]