Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update klaviyo ui to new UI layout #493

Merged
merged 14 commits into from
Jul 25, 2023
Merged

feat: update klaviyo ui to new UI layout #493

merged 14 commits into from
Jul 25, 2023

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Apr 3, 2023 •
edited
Loading

Description of the change

Update klaviyo ui to new UI layout

Screenshot

image

image

image

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ujjwal-ab ujjwal-ab self-assigned this Apr 3, 2023
@ujjwal-ab ujjwal-ab requested a review from utsabc April 3, 2023 05:45
@codecov
Copy link

codecov bot commented Apr 3, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc1569e) 100.00% compared to head (711502e) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop      #493   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@utsabc
Copy link
Member

utsabc commented Apr 3, 2023

Can you add screenshot of the UI?

@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@ujjwal-ab ujjwal-ab removed the Stale label May 23, 2023
@ujjwal-ab ujjwal-ab reopened this May 23, 2023
@devops-github-rudderstack
Copy link
Contributor

This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

@ujjwal-ab ujjwal-ab reopened this Jul 17, 2023
@ujjwal-ab ujjwal-ab removed the Stale label Jul 17, 2023
@ujjwal-ab ujjwal-ab merged commit 97b6b8f into develop Jul 25, 2023
5 checks passed
@ujjwal-ab ujjwal-ab self-assigned this Oct 11, 2023
@devops-github-rudderstack devops-github-rudderstack deleted the klaviyo-newUI branch October 25, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc left review comments

@sandeepdsvs sandeepdsvs sandeepdsvs approved these changes

@krishna2020 krishna2020 krishna2020 approved these changes

@lvrach lvrach Awaiting requested review from lvrach lvrach is a code owner

@cisse21 cisse21 Awaiting requested review from cisse21 cisse21 is a code owner

@nidhilashkari17 nidhilashkari17 Awaiting requested review from nidhilashkari17

@debanjan97 debanjan97 Awaiting requested review from debanjan97 debanjan97 is a code owner

@ssbeefeater ssbeefeater Awaiting requested review from ssbeefeater ssbeefeater is a code owner

@AchuthaSourabhC AchuthaSourabhC Awaiting requested review from AchuthaSourabhC

@ruchiramoitra ruchiramoitra Awaiting requested review from ruchiramoitra ruchiramoitra is a code owner

@ashishRudder ashishRudder Awaiting requested review from ashishRudder

@ItsSudip ItsSudip Awaiting requested review from ItsSudip ItsSudip is a code owner

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507 shrouti1507 is a code owner

@desusai7 desusai7 Awaiting requested review from desusai7

@1abhishekpandey 1abhishekpandey Awaiting requested review from 1abhishekpandey 1abhishekpandey is a code owner

@bardisg bardisg Awaiting requested review from bardisg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ujjwal-ab @utsabc @devops-github-rudderstack @krishna2020 @sandeepdsvs