Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create config generator script for os contribution #742

Merged
merged 17 commits into from
Aug 1, 2023

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Jun 29, 2023

Description of the change

  • This PR includes an addition of new config generator script that uses JSON with required minimum fields for generating a destination's configuration files (db-config, ui-config).
  • Includes test coverage for the above.

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e0e9495) 100.00% compared to head (6078a01) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #742   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write some tests

scripts/configGenerator.py Outdated Show resolved Hide resolved
koladilip
koladilip previously approved these changes Jul 13, 2023
koladilip
koladilip previously approved these changes Jul 17, 2023
@koladilip
Copy link
Collaborator

can you documentation on how to run the tests?

oscontrib/README.md Outdated Show resolved Hide resolved
oscontrib/README.md Outdated Show resolved Hide resolved
@ujjwal-ab ujjwal-ab merged commit 4d65441 into develop Aug 1, 2023
5 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the config-generator-script branch November 2, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants