Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update google ads #788

Merged
merged 1 commit into from
Jul 24, 2023
Merged

chore: update google ads #788

merged 1 commit into from
Jul 24, 2023

Conversation

debanjan97
Copy link
Member

@debanjan97 debanjan97 commented Jul 24, 2023

v6.2.0-fix-google-ads-error-handling

Ticket Link

https://linear.app/rudderstack/issue/RUD-328/validate-calls-fail-with-unexpected-end-of-json-input

Description of the change

Airbyte change log: rudderlabs/airbyte@v6.2.0...rudderlabs:airbyte:test-valueerror-googleads
Improves error handling which results in correct prompt in the UI

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

v6.2.0-fix-google-ads-error-handling
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9c2dfa0) 100.00% compared to head (5f5f1b0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #788   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@debanjan97 debanjan97 merged commit e773c21 into develop Jul 24, 2023
8 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the chore/gadsupdate branch October 25, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants