-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: catalog input field added for databricks #795
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #795 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 78 78
Branches 13 13
=========================================
Hits 78 78 ☔ View full report in Codecov by Sentry. |
shreyashghadge11
changed the title
feat: Catalog input added for Databricks
feat: catalog input added for Databricks
Jul 26, 2023
shreyashghadge11
changed the title
feat: catalog input added for Databricks
feat: catalog input field added for databricks
Aug 7, 2023
shreyashghadge11
requested review from
lvrach,
cisse21,
nidhilashkari17,
debanjan97,
ssbeefeater,
AchuthaSourabhC,
ruchiramoitra,
ashishRudder,
ItsSudip,
shrouti1507,
sandeepdsvs,
krishna2020,
desusai7,
1abhishekpandey and
bardisg
as code owners
August 16, 2023 05:11
ashishRudder
previously approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Vikas26021999
previously approved these changes
Aug 16, 2023
Vikas26021999
dismissed
ashishRudder’s stale review
August 16, 2023 14:46
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added input box for Catalog parameter in Databricks.
https://www.notion.so/Databricks-Unity-Catalog-Support-f8a0cb0f06af47b6985488a9e88a22e2
Checklists
Development
Code review