Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: catalog input field added for databricks #795

Closed
wants to merge 5 commits into from

Conversation

shreyashghadge11
Copy link
Contributor

@shreyashghadge11 shreyashghadge11 commented Jul 26, 2023

Description of the change

Added input box for Catalog parameter in Databricks.
https://www.notion.so/Databricks-Unity-Catalog-Support-f8a0cb0f06af47b6985488a9e88a22e2
image

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2ddb5d) 100.00% compared to head (e0e8619) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #795   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyashghadge11 shreyashghadge11 changed the title feat: Catalog input added for Databricks feat: catalog input added for Databricks Jul 26, 2023
@shreyashghadge11 shreyashghadge11 changed the title feat: catalog input added for Databricks feat: catalog input field added for databricks Aug 7, 2023
ashishRudder
ashishRudder previously approved these changes Aug 16, 2023
Copy link
Contributor

@ashishRudder ashishRudder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Vikas26021999
Vikas26021999 previously approved these changes Aug 16, 2023
@Vikas26021999 Vikas26021999 changed the base branch from develop to hotfix/fix.Aug16.08 August 16, 2023 14:45
@Vikas26021999 Vikas26021999 changed the base branch from hotfix/fix.Aug16.08 to develop August 16, 2023 14:46
@Vikas26021999 Vikas26021999 dismissed their stale review August 16, 2023 14:46

The base branch was changed.

@Vikas26021999 Vikas26021999 dismissed ashishRudder’s stale review August 16, 2023 14:46

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants